linux-kernel - Re: [PATCH v2 2/2] i2c: qup: support SMBus block read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573E205C.9080701@codeaurora.org>
Date:	Thu, 19 May 2016 15:21:48 -0500
From:	Timur Tabi <timur@...eaurora.org>
To:	Naveen Kaje <nkaje@...eaurora.org>,
	Sricharan <sricharan@...eaurora.org>, wsa@...-dreams.de,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	linux-arm-msm@...r.kernel.org, rruigrok@...eaurora.org,
	cov@...eaurora.org, austinwc@...eaurora.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] i2c: qup: support SMBus block read

Naveen Kaje wrote:
>>>
>>> +        tags[len++] = QUP_TAG_V2_DATARD;
>>> +        /* 0 implies 256 bytes */
>>> +        if (data_len == QUP_READ_LIMIT)
>>> +            tags[len++] = 0;
>>> +        else
>>> +            tags[len++] = data_len;
>>> +    }
>>         Even data_len will always be '1' right ?
> Yes, but here preferably we use a variable than a number without a context.

Actually, I would say the opposite.  I would rather see a constant with 
a comment explaining it, than a variable that we know will always 
contain only one number.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.