linux-kernel - Re: [PATCH] NVMe: fix deadlock on failure branch in nvme_get_ns_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160520230527.GA2839@localhost.localdomain>
Date:	Fri, 20 May 2016 19:05:28 -0400
From:	Keith Busch <keith.busch@...el.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Jens Axboe <axboe@...com>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] NVMe: fix deadlock on failure branch in
 nvme_get_ns_from_disk()

On Sat, May 21, 2016 at 01:36:00AM +0300, Alexey Khoroshilov wrote:
> kref_put(&ns->kref, nvme_free_ns) is called in nvme_get_ns_from_disk()
> under dev_list_lock spinlock, while nvme_free_ns() locks the spinlock
> by itself. This can lead to a deadlock.
> 
> The patch moves try_module_get() and its error handling
> out of spinlock section.

This is also fixed with this earlier posted patch:

  http://lists.infradead.org/pipermail/linux-nvme/2016-May/004530.html