linux-kernel - Re: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160523212813.GD11415@kroah.com>
Date:	Mon, 23 May 2016 14:28:13 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Winkler, Tomas" <tomas.winkler@...el.com>
Cc:	"Usyskin, Alexander" <alexander.usyskin@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [char-misc-next 1/2] mei: don't use wake_up_interruptible for
 wr_ctrl

On Mon, May 23, 2016 at 01:07:53PM +0000, Winkler, Tomas wrote:
> > 
> > From: Alexander Usyskin <alexander.usyskin@...el.com>
> > 
> > wr_ctrl waiters are none interruptible, so should be waken up with call to
> > wake_up and not to wake_up_interruptible.
> > 
> > This fixes commit:
> > 7ff4bdd ("mei: fix waiting for wr_ctrl for corner cases.")
> > 
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@...el.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> 
> Hi Greg,
> I see this fix didn't make it to rc1, so currently the  driver is somehow broken.
> Can you please make an effort and include the fix in next rc? 

Ugh, didn't realize it was totally broken, the patch didn't really say
that, sorry.  I'll queue it up once 4.7-rc1 is out.

thanks,

greg k-h