lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160524085406.GC12860@in.ibm.com> Date: Tue, 24 May 2016 14:24:06 +0530 From: Gautham R Shenoy <ego@...ux.vnet.ibm.com> To: "Shreyas B. Prabhu" <shreyas@...ux.vnet.ibm.com> Cc: mpe@...erman.id.au, linuxppc-dev@...ts.ozlabs.org, paulus@...abs.org, linux-kernel@...r.kernel.org, mikey@...ling.org, ego@...ux.vnet.ibm.com Subject: Re: [PATCH v3 4/9] powerpc/powernv: Make power7_powersave_common more generic Hi Shreyas, On Mon, May 23, 2016 at 08:48:37PM +0530, Shreyas B. Prabhu wrote: > power7_powersave_common does common steps needed before entering idle > state and eventually changes MSR to MSR_IDLE and does rfid to > power7_enter_nap_mode. > > Move the updation of HSTATE_HWTHREAD_STATE to power7_powersave_common > from power7_enter_nap_mode and make it more generic by passing the rfid > address as a function parameter. > > Also make function name more generic. > > Reviewed-by: Gautham R. Shenoy <ego@...ux.vnet.ibm.com> > Signed-off-by: Shreyas B. Prabhu <shreyas@...ux.vnet.ibm.com> > --- > Changes in v3: > ============== > - Moved HSTATE_HWTHREAD_STATE updation to power_powersave_common > > arch/powerpc/kernel/idle_power_common.S | 30 +++++++++++++++++------------- > 1 file changed, 17 insertions(+), 13 deletions(-) > > diff --git a/arch/powerpc/kernel/idle_power_common.S b/arch/powerpc/kernel/idle_power_common.S > index 973c9a1..d100577 100644 > --- a/arch/powerpc/kernel/idle_power_common.S > +++ b/arch/powerpc/kernel/idle_power_common.S > @@ -74,8 +74,10 @@ core_idle_lock_held: > * To check IRQ_HAPPENED in r4 > * 0 - don't check > * 1 - check > + * > + * Address to 'rfid' to in r5 > */ > -_GLOBAL(power7_powersave_common) > +_GLOBAL(pnv_powersave_common) You can move this rename to the previous patch where it fits better. [..snip..] > > .globl power7_enter_nap_mode > power7_enter_nap_mode: Ditto. This should be "pnv_enter_idle_mode" in the previous patch. [..snip..] > > _GLOBAL(power7_winkle) > li r3,3 li r3,PNV_THREAD_WINKLE Which should be a separate patch.
Powered by blists - more mailing lists