lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160524090142.GI7917@esperanza> Date: Tue, 24 May 2016 12:01:42 +0300 From: Vladimir Davydov <vdavydov@...tuozzo.com> To: Michal Hocko <mhocko@...nel.org> CC: Andrew Morton <akpm@...ux-foundation.org>, Johannes Weiner <hannes@...xchg.org>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] mm: memcontrol: fix possible css ref leak on oom On Tue, May 24, 2016 at 10:47:37AM +0200, Michal Hocko wrote: > On Tue 24-05-16 11:43:19, Vladimir Davydov wrote: > > On Mon, May 23, 2016 at 07:44:43PM +0200, Michal Hocko wrote: > > > On Mon 23-05-16 19:02:10, Vladimir Davydov wrote: > > > > mem_cgroup_oom may be invoked multiple times while a process is handling > > > > a page fault, in which case current->memcg_in_oom will be overwritten > > > > leaking the previously taken css reference. > > > > > > Have you seen this happening? I was under impression that the page fault > > > paths that have oom enabled will not retry allocations. > > > > filemap_fault will, for readahead. > > I thought that the readahead is __GFP_NORETRY so we do not trigger OOM > killer. Hmm, interesting. We do allocate readahead pages with __GFP_NORETRY, but we add them to page cache and hence charge with GFP_KERNEL or GFP_NOFS mask, see __do_page_cache_readahaed -> read_pages.
Powered by blists - more mailing lists