linux-kernel - [PATCH 3/4] bcache: bch_gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1605241636220.31937@cbobk.fhfr.pm>
Date:	Tue, 24 May 2016 16:38:34 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Jens Axboe <axboe@...nel.dk>
cc:	Kent Overstreet <kent.overstreet@...il.com>,
	Eric Wheeler <bcache@...ts.ewheeler.net>,
	linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 3/4] bcache: bch_gc_thread() is not freezable

From: Jiri Kosina <jkosina@...e.cz>

bch_gc_thread() doesn't mark itself freezable, so calling try_to_freeze() 
in its context is just an expensive no-op.

Signed-off-by: Jiri Kosina <jkosina@...e.cz>
---
 drivers/md/bcache/btree.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 22b9e34..eab505e 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -27,7 +27,6 @@
 
 #include <linux/slab.h>
 #include <linux/bitops.h>
-#include <linux/freezer.h>
 #include <linux/hash.h>
 #include <linux/kthread.h>
 #include <linux/prefetch.h>
@@ -1787,7 +1786,6 @@ again:
 
 		mutex_unlock(&c->bucket_lock);
 
-		try_to_freeze();
 		schedule();
 	}
 
-- 
Jiri Kosina
SUSE Labs