lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1605241634270.31937@cbobk.fhfr.pm> Date: Tue, 24 May 2016 16:38:10 +0200 (CEST) From: Jiri Kosina <jikos@...nel.org> To: Jens Axboe <axboe@...nel.dk> cc: Kent Overstreet <kent.overstreet@...il.com>, Eric Wheeler <bcache@...ts.ewheeler.net>, linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 1/4] bcache: bch_writeback_thread() is not freezable From: Jiri Kosina <jkosina@...e.cz> bch_writeback_thread() is calling try_to_freeze(), but that's just an expensive no-op given the fact that the thread is not marked freezable. I/O helper kthreads, exactly such as the bcache writeback thread, actually shouldn't be freezable, because they are potentially necessary for finalizing the image write-out. Signed-off-by: Jiri Kosina <jkosina@...e.cz> --- This is a resend of a series sent more than a month ago and pinged multiple time since then. drivers/md/bcache/writeback.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c index b9346cd..6012367 100644 --- a/drivers/md/bcache/writeback.c +++ b/drivers/md/bcache/writeback.c @@ -12,7 +12,6 @@ #include "writeback.h" #include <linux/delay.h> -#include <linux/freezer.h> #include <linux/kthread.h> #include <trace/events/bcache.h> @@ -228,7 +227,6 @@ static void read_dirty(struct cached_dev *dc) */ while (!kthread_should_stop()) { - try_to_freeze(); w = bch_keybuf_next(&dc->writeback_keys); if (!w) @@ -433,7 +431,6 @@ static int bch_writeback_thread(void *arg) if (kthread_should_stop()) return 0; - try_to_freeze(); schedule(); continue; } -- Jiri Kosina SUSE Labs
Powered by blists - more mailing lists