lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1605241635410.31937@cbobk.fhfr.pm> Date: Tue, 24 May 2016 16:38:15 +0200 (CEST) From: Jiri Kosina <jikos@...nel.org> To: Jens Axboe <axboe@...nel.dk> cc: Kent Overstreet <kent.overstreet@...il.com>, Eric Wheeler <bcache@...ts.ewheeler.net>, linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 2/4] bcache: bch_allocator_thread() is not freezable From: Jiri Kosina <jkosina@...e.cz> bch_allocator_thread() is calling try_to_freeze(), but that's just an expensive no-op given the fact that the thread is not marked freezable. Bucket allocator has to be up and running to the very last stages of the suspend, as the bcache I/O that's in flight (think of writing an hibernation image to a swap device served by bcache). Signed-off-by: Jiri Kosina <jkosina@...e.cz> --- drivers/md/bcache/alloc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/bcache/alloc.c b/drivers/md/bcache/alloc.c index 8eeab72..ca4abe1 100644 --- a/drivers/md/bcache/alloc.c +++ b/drivers/md/bcache/alloc.c @@ -64,7 +64,6 @@ #include "btree.h" #include <linux/blkdev.h> -#include <linux/freezer.h> #include <linux/kthread.h> #include <linux/random.h> #include <trace/events/bcache.h> @@ -288,7 +287,6 @@ do { \ if (kthread_should_stop()) \ return 0; \ \ - try_to_freeze(); \ schedule(); \ mutex_lock(&(ca)->set->bucket_lock); \ } \ -- Jiri Kosina SUSE Labs
Powered by blists - more mailing lists