linux-kernel - Re: [PATCH 1/4] bcache: bch_writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57446CB5.6080203@kernel.dk>
Date:	Tue, 24 May 2016 09:01:09 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Kent Overstreet <kent.overstreet@...il.com>,
	Eric Wheeler <bcache@...ts.ewheeler.net>,
	linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] bcache: bch_writeback_thread() is not freezable

On 05/24/2016 08:38 AM, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
>
> bch_writeback_thread() is calling try_to_freeze(), but that's just an
> expensive no-op given the fact that the thread is not marked freezable.
>
> I/O helper kthreads, exactly such as the bcache writeback thread, actually
> shouldn't be freezable, because they are potentially necessary for
> finalizing the image write-out.

Applied 1-4, thanks Jiri.

-- 
Jens Axboe