lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1464120473-1808-3-git-send-email-v1ron@mail.ru> Date: Tue, 24 May 2016 23:07:53 +0300 From: Roman Volkov <v1ron@...l.ru> To: Arnd Bergmann <arnd@...db.de> Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, Stephen Boyd <sboyd@...eaurora.org>, Michael Turquette <mturquette@...libre.com>, Roman Volkov <rvolkov@...os.org>, Tony Prisk <linux@...sktech.co.nz> Subject: [PATCH 2/2] clk/vt8500: Fix compilation warnings From: Roman Volkov <rvolkov@...os.org> GCC 5.3.0 still throws the following warnings for functions wm8750_find_pll_bits() and wm8850_find_pll_bits(): warning: 'best_div2' may be used uninitialized in this function warning: 'best_div1' may be used uninitialized in this function warning: 'best_mul' may be used uninitialized in this function These warnings are false positives, the variables are controlled by checking the value of the variable 'best_err' which is -1 by default. It is safe to initialize all these variables to zero. Fixes: 090341b0a95d ("clk: vt8500: fix sign of possible PLL values") Signed-off-by: Roman Volkov <rvolkov@...os.org> --- drivers/clk/clk-vt8500.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index 77650f19a9b6..7c970d7c0a6a 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -461,7 +461,7 @@ static int wm8750_find_pll_bits(unsigned long rate, unsigned long parent_rate, { u32 mul; int div1, div2; - u32 best_mul, best_div1, best_div2; + u32 best_mul = 0, best_div1 = 0, best_div2 = 0; unsigned long tclk, rate_err, best_err; best_err = (unsigned long)-1; @@ -513,7 +513,7 @@ static int wm8850_find_pll_bits(unsigned long rate, unsigned long parent_rate, { u32 mul; int div1, div2; - u32 best_mul, best_div1, best_div2; + u32 best_mul = 0, best_div1 = 0, best_div2 = 0; unsigned long tclk, rate_err, best_err; best_err = (unsigned long)-1; -- 2.8.0
Powered by blists - more mailing lists