lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160524030235.GA5856@sejong> Date: Tue, 24 May 2016 12:02:35 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Steven Rostedt <rostedt@...dmis.org> CC: LKML <linux-kernel@...r.kernel.org>, Masami Hiramatsu <mhiramat@...nel.org>, Shuah Khan <shuahkhan@...il.com>, <linux-kselftest@...r.kernel.org> Subject: Re: [RFC][PATCH] ftracetest: Fix hist unsupported result in hist selftests On Mon, May 23, 2016 at 10:32:43PM -0400, Steven Rostedt wrote: > On Tue, 24 May 2016 11:16:31 +0900 > Namhyung Kim <namhyung@...nel.org> wrote: > > > > Why not checking "hist" file then? > > I guess that could be done too, but is there anything wrong with my > current solution? Or is it just too hacky? How would one check if > something exists in a file or not? Say, I want to detect if > preemptirqsoff tracer exists or not, and that only happens if I do a > grep of current_tracer (I have tests coming that will need to do that)? There's nothing wrong with your approach IMHO. But I think checking existence of a file is clearer and consistent to other tests. For the preemptirqsoff tracer case, it seems there's no other way to check it simply. It's not hacky to me grep-ing contents to check availability of some option. Thanks, Namhyung
Powered by blists - more mailing lists