linux-kernel - Re: [PATCH] lightnvm: clear reserved bit on generic addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57455021.6080204@lightnvm.io>
Date:	Wed, 25 May 2016 09:11:29 +0200
From:	Matias Bjørling <mb@...htnvm.io>
To:	Javier González <jg@...htnvm.io>
Cc:	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	Javier González <javier@...xlabs.com>
Subject: Re: [PATCH] lightnvm: clear reserved bit on generic addr

On 05/11/2016 02:08 PM, Javier González wrote:
> When an address is converted from device to generic mode, the reserved
> bit needs to be cleared in order to signal that the address points to a
> flash block, not to a cacheline on the write buffer.
>
> Signed-off-by: Javier González <javier@...xlabs.com>
> ---
>   include/linux/lightnvm.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
> index 45be892..3d2c380 100644
> --- a/include/linux/lightnvm.h
> +++ b/include/linux/lightnvm.h
> @@ -418,6 +418,9 @@ static inline struct ppa_addr dev_to_generic_addr(struct nvm_dev *dev,
>   	l.g.ch |= (r.ppa >> dev->ppaf.ch_offset) &
>   					(((1 << dev->ppaf.ch_len) - 1));
>
> +	/* On device side, reserved bit is always 0 */
> +	l.g.reserved = 0;
> +
>   	return l;
>   }
>
>

Thanks Javier. Applied for 4.8. I have changed it to l.ppa = 0 and 
updated the description a bit.