linux-kernel - Re: [PATCH v9] fs: clear file privilege bits when mmap writing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160525214935.GI14480@ZenIV.linux.org.uk>
Date:	Wed, 25 May 2016 22:49:35 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Kees Cook <keescook@...omium.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Konstantin Khlebnikov <koct9i@...il.com>,
	Andy Lutomirski <luto@...capital.net>, Jan Kara <jack@...e.cz>,
	yalin wang <yalin.wang2010@...il.com>,
	Willy Tarreau <w@....eu>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9] fs: clear file privilege bits when mmap writing

On Wed, May 25, 2016 at 02:36:57PM -0700, Kees Cook wrote:

> Hm, this didn't end up getting picked up. (This jumped out at me again
> because i_mutex just vanished...)
> 
> Al, what's the right way to update the locking in this patch?

->i_mutex is dealt with just by using lock_inode(inode)/unlock_inode(inode);
I hadn't looked at the rest of the locking in there.