linux-kernel - Re: [PATCH 0/7] zram: switch to crypto api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 May 2016 09:52:32 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	<linux-kernel@...r.kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCH 0/7] zram: switch to crypto api

On Wed, May 25, 2016 at 11:29:59PM +0900, Sergey Senozhatsky wrote:
> Hello,
> 
>   This has started as a 'add zlib support' work, but after some
> thinking I saw no blockers for a bigger change -- a switch to
> crypto API.
> 
>   We don't have an idle zstreams list anymore and our write path
> now works absolutely differently, preventing preemption during
> compression. This removes possibilities of read paths preempting
> writes at wrong places and opens the door for a move from custom
> LZO/LZ4 compression backends implementation to a more generic one,
> using crypto compress API.
> 
>   This patch set also eliminates the need of a new context-less
> crypto API interface, which was quite hard to sell, so we can
> move along faster.

Super fast Sergey.
At a first glance, patchset looks nice.
I will review as soon as possible.

Thanks a lot!

> 
> 
> Sergey Senozhatsky (7):
>   zram: rename zstrm find-release functions
>   zram: switch to crypto compress API
>   zram: drop zcomp param from compress/decompress
>   zram: align zcomp interface to crypto comp API
>   zram: use crypto api to check alg availability
>   zram: delete custom lzo/lz4
>   zram: add more compression algorithms
> 
>  drivers/block/zram/Kconfig     | 15 +------
>  drivers/block/zram/Makefile    |  4 +-
>  drivers/block/zram/zcomp.c     | 91 +++++++++++++++++++++++++++---------------
>  drivers/block/zram/zcomp.h     | 29 ++++----------
>  drivers/block/zram/zcomp_lz4.c | 56 --------------------------
>  drivers/block/zram/zcomp_lz4.h | 17 --------
>  drivers/block/zram/zcomp_lzo.c | 56 --------------------------
>  drivers/block/zram/zcomp_lzo.h | 17 --------
>  drivers/block/zram/zram_drv.c  | 26 +++++++-----
>  9 files changed, 84 insertions(+), 227 deletions(-)
>  delete mode 100644 drivers/block/zram/zcomp_lz4.c
>  delete mode 100644 drivers/block/zram/zcomp_lz4.h
>  delete mode 100644 drivers/block/zram/zcomp_lzo.c
>  delete mode 100644 drivers/block/zram/zcomp_lzo.h
> 
> -- 
> 2.8.3.394.g3916adf
>