linux-kernel - Re: [PATCH 7/7] staging: dgnc: remove useless variable 'ch_intr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57483677.3020607@osg.samsung.com>
Date:	Fri, 27 May 2016 12:58:47 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Daeseok Youn <daeseok.youn@...il.com>, lidza.louina@...il.com
CC:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] staging: dgnc: remove useless variable 'ch_intr_rx'

On 27/05/16 07:55, Daeseok Youn wrote:
> The 'ch_intr_rx' variable was used only for increasing.
> So the 'ch_intr_rx' variable is not useful for this driver.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c    | 1 -
>  drivers/staging/dgnc/dgnc_driver.h | 2 --
>  drivers/staging/dgnc/dgnc_neo.c    | 2 --
>  3 files changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 695f8ce..fb74968 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -387,7 +387,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, uint port)
>  		/* Receive Interrupt pending */
>  		if (isr & (UART_IIR_RDI | UART_IIR_RDI_TIMEOUT)) {
>  			/* Read data from uart -> queue */
> -			ch->ch_intr_rx++;
>  			cls_copy_data_from_uart_to_queue(ch);
>  			dgnc_check_queue_flow_control(ch);
>  		}
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 8bdf556..3092abe 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -377,8 +377,6 @@ struct channel_t {
>  	ulong		ch_xon_sends;	/* Count of xons transmitted */
>  	ulong		ch_xoff_sends;	/* Count of xoffs transmitted */
>  
> -	ulong		ch_intr_rx;	/* Count of interrupts */
> -
>  	/* /proc/<board>/<channel> entries */
>  	struct proc_dir_entry *proc_entry_pointer;
>  	struct dgnc_proc_entry *dgnc_channel_table;
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 574a227..5ef5b3e 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -399,7 +399,6 @@ static inline void neo_parse_isr(struct dgnc_board *brd, uint port)
>  
>  		if (isr & (UART_17158_IIR_RDI_TIMEOUT | UART_IIR_RDI)) {
>  			/* Read data from uart -> queue */
> -			ch->ch_intr_rx++;
>  			neo_copy_data_from_uart_to_queue(ch);
>  
>  			/* Call our tty layer to enforce queue flow control if needed. */
> @@ -512,7 +511,6 @@ static inline void neo_parse_lsr(struct dgnc_board *brd, uint port)
>  	ch->ch_cached_lsr |= linestatus;
>  
>  	if (ch->ch_cached_lsr & UART_LSR_DR) {
> -		ch->ch_intr_rx++;
>  		/* Read data from uart -> queue */
>  		neo_copy_data_from_uart_to_queue(ch);
>  		spin_lock_irqsave(&ch->ch_lock, flags);
> 

Applied and checked them all. They look good.

Surprising amount of unused variables. Only set but never read.

Thanks Daeseok!
Luis