linux-kernel - Re: [PATCH 1/3] pvclock: Add CPU barries to get correct version value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXWKzTh6fxC0hhD=dPcxX=O1OKzsxxXw4-1fR=doY428A@mail.gmail.com>
Date:	Fri, 27 May 2016 08:39:50 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Minfei Huang <mnghuan@...il.com>
Cc:	Borislav Petkov <bp@...e.de>, Paolo Bonzini <pbonzini@...hat.com>,
	Andrew Lutomirski <luto@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] pvclock: Add CPU barries to get correct version value

On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@...il.com> wrote:
> Protocol for the "version" fields is: hypervisor raises it (making it
> uneven) before it starts updating the fields and raises it again (making
> it even) when it is done.  Thus the guest can make sure the time values
> it got are consistent by checking the version before and after reading
> them.
>
> Add CPU barries after getting version value just like what function
> vread_pvclock does, because all of callees in this function is inline.

LGTM.