linux-kernel - Re: [PATCH 2/3] pvclock: Cleanup to remove function pvclock_get_nsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXzeinwmfgJN3i8X6_6wiqxcL_RcadPJBHcPvKqWJh+8g@mail.gmail.com>
Date:	Fri, 27 May 2016 08:40:23 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Minfei Huang <mnghuan@...il.com>
Cc:	Borislav Petkov <bp@...e.de>, Paolo Bonzini <pbonzini@...hat.com>,
	Andrew Lutomirski <luto@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] pvclock: Cleanup to remove function pvclock_get_nsec_offset

On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@...il.com> wrote:
> Function __pvclock_read_cycles is short enough, so there is no need to
> have another function pvclock_get_nsec_offset to calculate tsc delta.
> It's better to combine it into function __pvclock_read_cycles.
>
> Remove useless variables in function __pvclock_read_cycles.

LGTM.