linux-kernel - Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 May 2016 08:40:49 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Minfei Huang <mnghuan@...il.com>
Cc:	Borislav Petkov <bp@...e.de>, Paolo Bonzini <pbonzini@...hat.com>,
	Andrew Lutomirski <luto@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get
 variable flags

On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mnghuan@...il.com> wrote:
> There is a generic function __pvclock_read_cycles to be used to get both
> flags and cycles. For function pvclock_read_flags, it's useless to get
> cycles value. To make this function be more effective, add a new wrapper
> function to only get variable flags.

Why not just get rid of this function entirely?