linux-kernel - Re: [PATCH] x86/mce: Do not use bank 1 for APEI generated error logs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160528073404.GA4584@nazgul.tnic>
Date:	Sat, 28 May 2016 09:34:04 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Tony Luck <tony.luck@...el.com>
Cc:	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	Aristeu Rozanski <arozansk@...hat.com>
Subject: Re: [PATCH] x86/mce: Do not use bank 1 for APEI generated error logs.

On Fri, May 27, 2016 at 02:11:06PM -0700, Tony Luck wrote:
> diff --git a/arch/x86/kernel/cpu/mcheck/mce-apei.c b/arch/x86/kernel/cpu/mcheck/mce-apei.c
> index 34c89a3e8260..9d2c02337713 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce-apei.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce-apei.c
> @@ -46,7 +46,7 @@ void apei_mce_report_mem_error(int severity, struct cper_sec_mem_err *mem_err)
>  		return;
>  
>  	mce_setup(&m);
> -	m.bank = 1;
> +	m.bank = mca_cfg.banks;

There's struct cper_sec_mem_err.bank. Why aren't we copying that?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--