linux-kernel - RE: [PATCH] x86/mce: Do not use bank 1 for APEI generated error logs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F3A0F71EC@ORSMSX114.amr.corp.intel.com>
Date:	Tue, 31 May 2016 17:11:45 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Aristeu Rozanski" <arozansk@...hat.com>
Subject: RE: [PATCH] x86/mce: Do not use bank 1 for APEI generated error
 logs.

>> -	m.bank = 1;
>> +	m.bank = mca_cfg.banks;
>
> There's struct cper_sec_mem_err.bank. Why aren't we copying that?

Because that is DDR3/DDR4 "bank" (internal DIMM detail) as opposed to machine check "bank"
(CPU microarchitecture detail).  We need the latter here.

-Tony