linux-kernel - Re: [v4,1/1] powerpc/86xx: Add support for Emerson/Artesyn MVME7100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPk1OjE_HsVm6cvvx5FHdTYAMWi2kJ2ChzPxsULS+PoW1CWqDQ@mail.gmail.com>
Date:	Mon, 30 May 2016 11:46:03 +0200
From:	Alessio Igor Bogani <alessio.bogani@...ttra.eu>
To:	Scott Wood <oss@...error.net>
Cc:	Kumar Gala <galak@...nel.crashing.org>,
	linuxppc-dev@...ts.ozlabs.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [v4,1/1] powerpc/86xx: Add support for Emerson/Artesyn MVME7100

Hi Scott,

On 17 May 2016 at 01:41, Scott Wood <oss@...error.net> wrote:
> On Wed, Apr 27, 2016 at 10:35:25AM +0200, Alessio Igor Bogani wrote:
>> +             bcsr@4,0 {
>> +                     compatible = "artesyn,mvme7100-bcsr";
>> +                     reg = <4 0 0x10000>;
>> +             };
>> +
>> +            serial@5,1000 {
>> +                     cell-index = <2>;
>> +                     device_type = "serial";
>> +                     compatible = "ns16550";
>> +                     reg = <5 0x1000 0x100>;
>> +                     clock-frequency = <1843200>;
>> +                     interrupts = <11 1 0 0>;
>> +             };
>
> The "serial@5,1000" line has spaces where there should be tabs.  There
> are several other instances of this in the patch.
>
> Where did these cell-index values come from?  Why are they needed?

I thought that was the right way to specify the serial number (aka
ttySXX) but I was wrong. I'll remove these.

Thank you very much!

Ciao,
Alessio