linux-kernel - Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160530125802.GA2800@linux-7smt.suse>
Date:	Mon, 30 May 2016 20:58:04 +0800
From:	Peng Fan <van.freenix@...il.com>
To:	linus.walleij@...aro.org, shawnguo@...nel.org
Cc:	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Stefan Agner <stefan@...er.ch>,
	Vladimir Zapolskiy <vz@...ia.com>
Subject: Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl_desc

Hi Linus, Shawn

Kindly ping.. Do you have any comments on this patch?

Thanks,
Peng.
On Wed, May 18, 2016 at 05:31:59PM +0800, Peng Fan wrote:
>To i.MX7D, there are two iomux controllers, iomuxc and iomuxc_lpsr.
>They should not share one pin controller descriptor, otherwise
>the value filled into imx_pinctrl_desc when probing the first
>iomux controller will be overridden when probing the second one.
>
>In this patch, discard the static allcoated imx_pinctrl_desc and
>switch to dynamically allcate pin controller descriptor for each
>iomux controller.
>
>Signed-off-by: Peng Fan <van.freenix@...il.com>
>Cc: Linus Walleij <linus.walleij@...aro.org>
>Cc: Shawn Guo <shawnguo@...nel.org>
>Cc: Philipp Zabel <p.zabel@...gutronix.de>
>Cc: Stefan Agner <stefan@...er.ch>
>Cc: Vladimir Zapolskiy <vz@...ia.com>
>---
> drivers/pinctrl/freescale/pinctrl-imx.c | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
>index 9cfa544..40fe939 100644
>--- a/drivers/pinctrl/freescale/pinctrl-imx.c
>+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
>@@ -513,13 +513,6 @@ static const struct pinconf_ops imx_pinconf_ops = {
> 	.pin_config_group_dbg_show = imx_pinconf_group_dbg_show,
> };
> 
>-static struct pinctrl_desc imx_pinctrl_desc = {
>-	.pctlops = &imx_pctrl_ops,
>-	.pmxops = &imx_pmx_ops,
>-	.confops = &imx_pinconf_ops,
>-	.owner = THIS_MODULE,
>-};
>-
> /*
>  * Each pin represented in fsl,pins consists of 5 u32 PIN_FUNC_ID and
>  * 1 u32 CONFIG, so 24 types in total for each pin.
>@@ -722,6 +715,7 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> {
> 	struct regmap_config config = { .name = "gpr" };
> 	struct device_node *dev_np = pdev->dev.of_node;
>+	struct pinctrl_desc *imx_pinctrl_desc;
> 	struct device_node *np;
> 	struct imx_pinctrl *ipctl;
> 	struct resource *res;
>@@ -776,9 +770,18 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> 		}
> 	}
> 
>-	imx_pinctrl_desc.name = dev_name(&pdev->dev);
>-	imx_pinctrl_desc.pins = info->pins;
>-	imx_pinctrl_desc.npins = info->npins;
>+	imx_pinctrl_desc = devm_kzalloc(&pdev->dev, sizeof(*imx_pinctrl_desc),
>+					GFP_KERNEL);
>+	if (!imx_pinctrl_desc)
>+		return -ENOMEM;
>+
>+	imx_pinctrl_desc->name = dev_name(&pdev->dev);
>+	imx_pinctrl_desc->pins = info->pins;
>+	imx_pinctrl_desc->npins = info->npins;
>+	imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
>+	imx_pinctrl_desc->pmxops = &imx_pmx_ops,
>+	imx_pinctrl_desc->confops = &imx_pinconf_ops,
>+	imx_pinctrl_desc->owner = THIS_MODULE,
> 
> 	ret = imx_pinctrl_probe_dt(pdev, info);
> 	if (ret) {
>@@ -789,7 +792,7 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> 	ipctl->info = info;
> 	ipctl->dev = info->dev;
> 	platform_set_drvdata(pdev, ipctl);
>-	ipctl->pctl = pinctrl_register(&imx_pinctrl_desc, &pdev->dev, ipctl);
>+	ipctl->pctl = pinctrl_register(imx_pinctrl_desc, &pdev->dev, ipctl);
> 	if (IS_ERR(ipctl->pctl)) {
> 		dev_err(&pdev->dev, "could not register IMX pinctrl driver\n");
> 		return PTR_ERR(ipctl->pctl);
>-- 
>2.6.2
>