linux-kernel - Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb5zv_YwbZw_=bcss=ssuqDPcXc6gDa+U0TsaN-8gie-w@mail.gmail.com>
Date:	Tue, 31 May 2016 10:55:16 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Peng Fan <van.freenix@...il.com>
Cc:	Shawn Guo <shawnguo@...nel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Stefan Agner <stefan@...er.ch>,
	Vladimir Zapolskiy <vz@...ia.com>
Subject: Re: [PATCH] pinctrl: imx: fix initialization of imx_pinctrl_desc

On Wed, May 18, 2016 at 11:31 AM, Peng Fan <van.freenix@...il.com> wrote:

> To i.MX7D, there are two iomux controllers, iomuxc and iomuxc_lpsr.
> They should not share one pin controller descriptor, otherwise
> the value filled into imx_pinctrl_desc when probing the first
> iomux controller will be overridden when probing the second one.
>
> In this patch, discard the static allcoated imx_pinctrl_desc and
> switch to dynamically allcate pin controller descriptor for each
> iomux controller.
>
> Signed-off-by: Peng Fan <van.freenix@...il.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Stefan Agner <stefan@...er.ch>
> Cc: Vladimir Zapolskiy <vz@...ia.com>

Looks reasonable to me so patch applied since noone is responding.

Yours,
Linus Walleij