linux-kernel - Re: Re: [RESEND][PATCH] drivers: of: of_reserved_mem: fixup the CMA alignment not to affect dma-coherent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2016 17:45:15 +0900
From:	Jaewon Kim <jaewon31.kim@...sung.com>
To:	robh+dt@...nel.org, m.szyprowski@...sung.com
Cc:	r64343@...escale.com, grant.likely@...aro.org,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	jaewon31.kim@...il.com
Subject: Re: Re: [RESEND][PATCH] drivers: of: of_reserved_mem: fixup the CMA
 alignment not to affect dma-coherent

>Hello,
>
>
>On 2016-05-25 16:38, Rob Herring wrote:
>> On Tue, May 24, 2016 at 11:29 PM, Jaewon Kim <jaewon31.kim@...sung.com> wrote:
>>> From: Jaewon <jaewon31.kim@...sung.com>
>>>
>>> There was an alignment mismatch issue for CMA and it was fixed by
>>> commit 1cc8e3458b51 ("drivers: of: of_reserved_mem: fixup the alignment with CMA setup").
>>> However the way of the commit considers not only dma-contiguous(CMA) but also
>>> dma-coherent which has no that requirement.
>>>
>>> This patch checks more to distinguish dma-contiguous(CMA) from dma-coherent.
>>>
>>> Signed-off-by: Jaewon Kim <jaewon31.kim@...sung.com>
>> I suppose this needs to go to stable? If so, adding the stable tag and
>> kernel version would be nice so I don't have to.

Hello

In my opinion, this patch is not that critical.
Commit 1cc8e3458b51 might move unaligned(pageblock size) dma-coherent region.
And this patch will move the region back to different address which is aligned less than pageblock size.
But if you think it need to stable branch, please let me know how to add the stable tag.

>>
>>> ---
>>>   drivers/of/of_reserved_mem.c | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>> I'm looking for an ack from Marek on this.
>
>Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

Thank you for your Ack
>
>Best regards
>--
>Marek Szyprowski, PhD
>Samsung R&D Institute Poland