linux-kernel - Re: [PATCH] perf/x86/intel/rapl: add skylake server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160531092908.GV3192@twins.programming.kicks-ass.net>
Date:	Tue, 31 May 2016 11:29:08 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH] perf/x86/intel/rapl: add skylake server

On Tue, May 24, 2016 at 09:31:43AM -0700, Jacob Pan wrote:
> SKX uses similar RAPL interface as Broadwell server.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> ---
>  arch/x86/events/intel/rapl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/events/intel/rapl.c b/arch/x86/events/intel/rapl.c
> index 1705c9d..70af62a 100644
> --- a/arch/x86/events/intel/rapl.c
> +++ b/arch/x86/events/intel/rapl.c
> @@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void)
>  		break;
>  	case 63: /* Haswell-Server */
>  	case 79: /* Broadwell-Server */
> +	case 85: /* Skylake-Server */
>  		apply_quirk = true;
>  		rapl_cntr_mask = RAPL_IDX_SRV;
>  		rapl_pmu_events_group.attrs = rapl_events_srv_attr;

This does not apply; please try against a more recent kernel. In
specific commit:

  4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver modular")

seems to the 'problem'.