linux-kernel - Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2016 09:31:32 +0800
From:	Yuyang Du <yuyang.du@...el.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	mingo@...nel.org, linux-kernel@...r.kernel.org,
	umgwanakikbuti@...il.com, bsegall@...gle.com, pjt@...gle.com,
	morten.rasmussen@....com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com
Subject: Re: [RFC PATCH 1/2] sched: Clean up SD_BALANCE_WAKE flags in sched
 domain build-up

On Tue, May 31, 2016 at 11:21:46AM +0200, Peter Zijlstra wrote:
> On Tue, May 31, 2016 at 09:11:37AM +0800, Yuyang Du wrote:
> > The SD_BALANCE_WAKE is irrelevant in the contexts of these two removals,
> > and in addition SD_BALANCE_WAKE is not and should not be set in any
> > sched_domain flags so far.
> 
> This Changelog doesn't make any sense...

How? SD_BALANCE_WAKE is not in any sched_domain flags (sd->flags), even if
it is, it is not used anywhere, no?
 
> > Signed-off-by: Yuyang Du <yuyang.du@...el.com>
> > ---
> >  kernel/sched/core.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 7f2cae4..e00b8ea 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -6229,10 +6229,10 @@ static void set_domain_attribute(struct sched_domain *sd,
> >  		request = attr->relax_domain_level;
> >  	if (request < sd->level) {
> >  		/* turn off idle balance on this domain */
> > -		sd->flags &= ~(SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> > +		sd->flags &= ~(SD_BALANCE_NEWIDLE);
> >  	} else {
> >  		/* turn on idle balance on this domain */
> > -		sd->flags |= (SD_BALANCE_WAKE|SD_BALANCE_NEWIDLE);
> > +		sd->flags |= (SD_BALANCE_NEWIDLE);
> >  	}
> >  }
> >  
> > -- 
> > 1.7.9.5
> >