linux-kernel - Re: fou: dead build rule for fou6.o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6480044.hX0Y0pDViW@wuerfel>
Date:	Tue, 31 May 2016 12:08:34 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	davem@...emloft.net, LKML <linux-kernel@...r.kernel.org>,
	Andreas Ziegler <ziegler@...fau.de>
Subject: Re: fou: dead build rule for fou6.o

On Tuesday, May 31, 2016 8:25:40 AM CEST Valentin Rothberg wrote:
> Hi Arnd,
> 
> your commit fabb13db448e ("fou: add Kconfig options for IPv6 support")
> has shown up in today's linux-next. ./scripts/checkkconfigsymbols.py
> warned because of the following statement in net/ipv6/Makefile:
> 
> +obj-$(CONFIG_NET_FOU_IPV6_TUNNELS) += fou6.o

Thanks for the report, that was indeed a mistake.

> The referenced Kconfig option does not exist, but I assume the right
> option is 'IPV6_FOU_TUNNEL'?  In case yes, the modified #if block in
> the commit could be removed (redundant check).

It's supposed to be CONFIG_IPV6_FOU, not CONFIG_IPV6_FOU_TUNNEL.
I've put that into my randconfig builder now to see if I get any
other regressions with that. What happened here is that after my
incorrect patch, the file never got built, so I did not see build
errors either. However it is possible that I made another mistake
in the same patch and it needs more changes, so let me first check
if this one-line change works correctly.

	Arnd