linux-kernel - Re: fou: dead build rule for fou6.o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4806183.jXJkFW1R6y@wuerfel>
Date:	Tue, 31 May 2016 15:18:34 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	davem@...emloft.net, LKML <linux-kernel@...r.kernel.org>,
	Andreas Ziegler <ziegler@...fau.de>
Subject: Re: fou: dead build rule for fou6.o

On Tuesday, May 31, 2016 8:25:40 AM CEST Valentin Rothberg wrote:
> Hi Arnd,
> 
> your commit fabb13db448e ("fou: add Kconfig options for IPv6 support")
> has shown up in today's linux-next. ./scripts/checkkconfigsymbols.py
> warned because of the following statement in net/ipv6/Makefile:
> 
> +obj-$(CONFIG_NET_FOU_IPV6_TUNNELS) += fou6.o
> 
> The referenced Kconfig option does not exist, but I assume the right
> option is 'IPV6_FOU_TUNNEL'?  In case yes, the modified #if block in
> the commit could be removed (redundant check).

I found another mistake that was hidden by the one you found.
The option controlling the file is IPV6_TUNNEL, not INET6_TUNNEL.
I'm currently testing with the patch below to address both bugs.

	Arnd

diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index 994608263260..2343e4f2e0bf 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -239,7 +239,7 @@ config IPV6_FOU
 config IPV6_FOU_TUNNEL
 	tristate
 	default NET_FOU_IP_TUNNELS && IPV6_FOU
-	select INET6_TUNNEL
+	select IPV6_TUNNEL
 
 config IPV6_MULTIPLE_TABLES
 	bool "IPv6: Multiple Routing Tables"
diff --git a/net/ipv6/Makefile b/net/ipv6/Makefile
index d42ca3d1197f..6d8ea099213e 100644
--- a/net/ipv6/Makefile
+++ b/net/ipv6/Makefile
@@ -42,7 +42,7 @@ obj-$(CONFIG_IPV6_VTI) += ip6_vti.o
 obj-$(CONFIG_IPV6_SIT) += sit.o
 obj-$(CONFIG_IPV6_TUNNEL) += ip6_tunnel.o
 obj-$(CONFIG_IPV6_GRE) += ip6_gre.o
-obj-$(CONFIG_NET_FOU_IPV6_TUNNELS) += fou6.o
+obj-$(CONFIG_IPV6_FOU) += fou6.o
 
 obj-y += addrconf_core.o exthdrs_core.o ip6_checksum.o ip6_icmp.o
 obj-$(CONFIG_INET) += output_core.o protocol.o $(ipv6-offload)