linux-kernel - Re: [Xen-devel] [PATCH] xen: xenbus: Remove create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2016 17:18:14 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>, <tj@...nel.org>
CC:	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen: xenbus: Remove create_workqueue

On 27/05/16 19:50, Bhaktipriya Shridhar wrote:
> With concurrency managed workqueues, use of dedicated workqueues can be
> replaced by using system_wq. Drop xenbus_frontend_wq by using system_wq.
> 
> Since there is only a single work item, increase of concurrency level by
> switching to system_wq should not break anything.
> 
> Since the work item could be pending and the code expects it to run
> once scheduled, flush_work() has been used in xenbus_dev_suspend()

This says flush_work() but...
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
> ---
>  drivers/xen/xenbus/xenbus_probe.c          |  2 ++
>  drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +--------------
>  2 files changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 33a31cf..bc97019 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -592,6 +592,8 @@ int xenbus_dev_suspend(struct device *dev)
> 
>  	DPRINTK("%s", xdev->nodename);
> 
> +	cancel_work_sync(&xdev->work);

...cancel_work_sync() is called here.

David