linux-kernel - Re: [Xen-devel] [PATCH] xen: xenbus: Remove create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFNHFT8RF9x-itMGTHgdpcK2XA0gCkNPkbiC5y87zFnaQX_9aA@mail.gmail.com>
Date:	Tue, 31 May 2016 22:13:46 +0530
From:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>
To:	David Vrabel <david.vrabel@...rix.com>
Cc:	Tejun Heo <tj@...nel.org>, xen-devel@...ts.xenproject.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen: xenbus: Remove create_workqueue

Sorry about that. Will make the corrections in v2.

Thanks,
Bhaktipriya


On Tue, May 31, 2016 at 9:48 PM, David Vrabel <david.vrabel@...rix.com> wrote:
> On 27/05/16 19:50, Bhaktipriya Shridhar wrote:
>> With concurrency managed workqueues, use of dedicated workqueues can be
>> replaced by using system_wq. Drop xenbus_frontend_wq by using system_wq.
>>
>> Since there is only a single work item, increase of concurrency level by
>> switching to system_wq should not break anything.
>>
>> Since the work item could be pending and the code expects it to run
>> once scheduled, flush_work() has been used in xenbus_dev_suspend()
>
> This says flush_work() but...
>>
>> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>
>> ---
>>  drivers/xen/xenbus/xenbus_probe.c          |  2 ++
>>  drivers/xen/xenbus/xenbus_probe_frontend.c | 15 +--------------
>>  2 files changed, 3 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
>> index 33a31cf..bc97019 100644
>> --- a/drivers/xen/xenbus/xenbus_probe.c
>> +++ b/drivers/xen/xenbus/xenbus_probe.c
>> @@ -592,6 +592,8 @@ int xenbus_dev_suspend(struct device *dev)
>>
>>       DPRINTK("%s", xdev->nodename);
>>
>> +     cancel_work_sync(&xdev->work);
>
> ...cancel_work_sync() is called here.
>
> David