[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1464717537.14627.39.camel@perches.com>
Date: Tue, 31 May 2016 10:58:57 -0700
From: Joe Perches <joe@...ches.com>
To: Suzuki K Poulose <suzuki.poulose@....com>,
linux-arm-kernel@...ts.infradead.org
Cc: mathieu.poirier@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] coresight: Add better messages for coresight_timeout
On Tue, 2016-05-31 at 12:57 +0100, Suzuki K Poulose wrote:
> When we encounter a timeout waiting for a status change via
> coresight_timeout, the caller always print the offset which
> was tried. This is pretty much useless as it doesn't specify
> the bit position we wait for. Also, one needs to lookup the
> TRM to figure out, what was wrong. This patch changes all
> such error messages to print something more meaningful.
trivia:
Perhaps consistently using
dev_err(dev, "timeout while waiting for %s\n", "<foo>");
could make the object code a bit smaller.
> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
[]
> @@ -184,8 +184,7 @@ static void etb_disable_hw(struct etb_drvdata *drvdata)
>
> if (coresight_timeout(drvdata->base, ETB_FFCR, ETB_FFCR_BIT, 0)) {
> dev_err(drvdata->dev,
> - "timeout observed when probing at offset %#x\n",
> - ETB_FFCR);
> + "timeout while waiting for completion of Manual Flush\n");
ie:
dev_err(drvdata->dev,
"timeout while waiting for %s\n",
"completion of Manual Flush");
but that depends on how many of these coresight
files are compiled and linked.
There is a while/when usage difference in some of
the output messages.
Powered by blists - more mailing lists