linux-kernel - Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A3FEFDCF-9AE5-4C0B-B36E-E46A87F7229C@amd.com>
Date:	Wed, 1 Jun 2016 15:35:23 +0000
From:	"Huang, Ray" <Ray.Huang@....com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Borislav Petkov <bp@...en8.de>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	"Hurwitz, Sherry" <sherry.hurwitz@....com>
Subject: Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading
 registers


Sent from my iPad

> On Jun 1, 2016, at 11:27 PM, Huang, Ray <Ray.Huang@....com> wrote:
> 
> 
> 
>>> On Jun 1, 2016, at 9:23 PM, Guenter Roeck <linux@...ck-us.net> wrote:
>>> 
>>> On 06/01/2016 03:04 AM, Borislav Petkov wrote:
>>> From: Borislav Petkov <bp@...e.de>
>>> 
>>> We need to read a bunch of registers on each compute unit and possibly
>>> on the current CPU too. Disable preemption around it.
>> 
>> An explanation would be helpful. Is this a bug fix ? I would like to get
>> a confirmation from someone at AMD that this is really necessary.
>> 
> 
> This change looks good for me. But I am in office this week, I will test it on CZ platform next week.   :-)

Sorry, fix typo. I am *not* in office this week.

Rui