linux-kernel - Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9a103cc-a5cf-95d8-ee49-d44542dbcb1e@osg.samsung.com>
Date:	Wed, 1 Jun 2016 16:52:47 -0400
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Krzysztof Kozlowski <krzk@...nel.org>,
	Kevin Hilman <khilman@...nel.org>
Cc:	Kukjin Kim <kgene@...nel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-samsung-soc@...r.kernel.org,
	devicetree <devicetree@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>, linux-clk@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

Hello Krzysztof,

On 06/01/2016 04:06 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@...nel.org> wrote:
>> Hi Krzysztof,
>>
>> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure
>>> clocks for UART3 and enable it.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>>> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
>>
>> This patch landed in linux-next[1] and kernelci.org found a boot
>> regression on the exynos5410-odroidxu[2], where it looks like it's
>> faulting in clk_prepare().  Bisecting pointed to this patch.  I added
>> "status = disabled" back into the DTS on top of next-20160601[3] and
>> verified my odroid-XU to be booting fine again.
> 
> Hi,
> 
> Thanks for report. Indeed the patch brings up to the light an issue in
> serial driver. Fixed here:
> https://lkml.org/lkml/2016/5/31/570
> 
> I left the commit in my tree as it is correct (strictly speaking).
> Sorry for any trouble it makes.
>

Kevin pointed me to this issue over IRC and I was able to reproduce it in
my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver.

Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread.
 
> Best regards,
> Krzysztof
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America