linux-kernel - Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPcDZFaqL7+wT9d9iD7Y4QbZWPFQw2hTR3AzyU4K099WYA@mail.gmail.com>
Date:	Wed, 1 Jun 2016 22:06:21 +0200
From:	Krzysztof Kozlowski <krzk@...nel.org>
To:	Kevin Hilman <khilman@...nel.org>
Cc:	Kukjin Kim <kgene@...nel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Tomasz Figa <tomasz.figa@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-samsung-soc@...r.kernel.org,
	devicetree <devicetree@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>, linux-clk@...r.kernel.org,
	Javier Martinez Canillas <javier@....samsung.com>,
	Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410

On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@...nel.org> wrote:
> Hi Krzysztof,
>
> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure
>> clocks for UART3 and enable it.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>> Reviewed-by: Javier Martinez Canillas <javier@....samsung.com>
>
> This patch landed in linux-next[1] and kernelci.org found a boot
> regression on the exynos5410-odroidxu[2], where it looks like it's
> faulting in clk_prepare().  Bisecting pointed to this patch.  I added
> "status = disabled" back into the DTS on top of next-20160601[3] and
> verified my odroid-XU to be booting fine again.

Hi,

Thanks for report. Indeed the patch brings up to the light an issue in
serial driver. Fixed here:
https://lkml.org/lkml/2016/5/31/570

I left the commit in my tree as it is correct (strictly speaking).
Sorry for any trouble it makes.

Best regards,
Krzysztof