linux-kernel - Re: [PATCH] relay: fix potential memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160601145649.b1ca852264601ffaa451e6d4@linux-foundation.org>
Date:	Wed, 1 Jun 2016 14:56:49 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Zhouyi Zhou <yizhouzhou@....ac.cn>
Cc:	penberg@...nel.org, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, Zhouyi Zhou <zhouzhouyi@...il.com>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] relay: fix potential memory leak

On Wed,  1 Jun 2016 18:45:27 +0800 Zhouyi Zhou <yizhouzhou@....ac.cn> wrote:

> when relay_open_buf fails in relay_open, program will goto free_bufs,
> but chan is nowhere freed.

OK.

> In addition, give warning to users who forget to provide create file
> hook. 	 

Why?  What's the value in this?

If the user didn't provide ->create_buf_file then setup_callbacks()
will provide them with create_buf_file_default_callback() - what's
wrong with that?