linux-kernel - Re: Re: [PATCH] relay: fix potential memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13299a4.23e72.1550eb5d0fc.Coremail.yizhouzhou@ict.ac.cn>
Date:	Thu, 2 Jun 2016 09:24:04 +0800 (GMT+08:00)
From:	"Zhouyi Zhou" <yizhouzhou@....ac.cn>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	penberg@...nel.org, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, "Zhouyi Zhou" <zhouzhouyi@...il.com>,
	"Jens Axboe" <axboe@...nel.dk>
Subject: Re: Re: [PATCH] relay: fix potential memory leak

Thanks Andrew for reviewing
> > In addition, give warning to users who forget to provide create file
> > hook. 	 
> 
> Why?  What's the value in this?
> 
> If the user didn't provide ->create_buf_file then setup_callbacks()
> will provide them with create_buf_file_default_callback() - what's
> wrong with that?
> 
The beginners like me will probably call relay_open with base_filename 
and NULL callback or callback without create_buf_file hook. This call 
will fail in sub function relay_open_buf because 
create_buf_file_default_callback returns empty dentry. I guess it will
be good to warn beginners to provide filesystem related create hooks at
earlier stage or they fail without knowing what has happened.

Best wishes
Zhouyi