linux-kernel - Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602064428.GE1995@dhcp22.suse.cz>
Date:	Thu, 2 Jun 2016 08:44:29 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Geliang Tang <geliangtang@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Christoph Lameter <cl@...ux.com>,
	Mel Gorman <mgorman@...hsingularity.net>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mm/vmstat: remove unused header cpumask.h

On Thu 02-06-16 14:15:35, Geliang Tang wrote:
> Remove unused header cpumask.h from mm/vmstat.c.

what about for_each_online_cpu? Maybe it will get included transitively
from other header but I guess it is better to have a direct include
because transitive includes lead to unexpected compilation issues.

> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  mm/vmstat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 1b585f8..3653449 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -15,7 +15,6 @@
>  #include <linux/module.h>
>  #include <linux/slab.h>
>  #include <linux/cpu.h>
> -#include <linux/cpumask.h>
>  #include <linux/vmstat.h>
>  #include <linux/proc_fs.h>
>  #include <linux/seq_file.h>
> -- 
> 1.9.1
> 

-- 
Michal Hocko
SUSE Labs