linux-kernel - Re: [PATCH 4/4] mm/zsmalloc: remove unused header cpumask.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602071017.GA439@swordfish>
Date:	Thu, 2 Jun 2016 16:10:17 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Geliang Tang <geliangtang@...il.com>
Cc:	Minchan Kim <minchan@...nel.org>, Nitin Gupta <ngupta@...are.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] mm/zsmalloc: remove unused header cpumask.h

On (06/02/16 14:15), Geliang Tang wrote:
> Remove unused header cpumask.h from mm/zsmalloc.c.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>
> ---
>  mm/zsmalloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index b6d4f25..a93327e 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -57,7 +57,6 @@
>  #include <linux/slab.h>
>  #include <asm/tlbflush.h>
>  #include <asm/pgtable.h>
> -#include <linux/cpumask.h>
>  #include <linux/cpu.h>
>  #include <linux/vmalloc.h>
>  #include <linux/preempt.h>

NAK. I don't think it's "unused".

zs_register_cpu_notifier()
	for_each_online_cpu()


which is coming from include/linux/cpumask.h

#define for_each_online_cpu(cpu)   for_each_cpu((cpu), cpu_online_mask)

	-ss