linux-kernel - Re: [PATCH 01/32] arm64: Add platform selection for BCM2835.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Jun 2016 08:45:36 +0200
From:	Gerd Hoffmann <kraxel@...hat.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	linux-rpi-kernel@...ts.infradead.org,
	Eric Anholt <eric@...olt.net>, Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	Russell King <linux@...linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	"open list:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." 
	<bcm-kernel-feedback-list@...adcom.com>,
	"moderated list:ARM SUB-ARCHITECTURES" 
	<linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/32] arm64: Add platform selection for BCM2835.

> >  config ARCH_BCM2835
> >  	bool "Broadcom BCM2835 family"
> > -	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7
> > +	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7 || ARM64
> 
> Humm, what does that achieve?

Nothing ;)

Slipped through unnoticed, I'll drop it.

> > +config ARCH_BCM
> > +	bool "Broadcom SoC Support"
> > +	help
> > +	  This enables support for Broadcom ARM based SoC chips
> 
> menuconfig maybe?

There isn't any in arch/arm64/Kconfig.platforms right now, so I didn't
feel like introducing one.  Also the dependency should have pretty much
the same effect ...

> > +config ARCH_BCM2835
> > +	bool "Broadcom BCM2835 family"
> > +	depends on ARCH_BCM
> > +	select ARCH_REQUIRE_GPIOLIB
> > +	select CLKSRC_OF
> > +	select PINCTRL
> > +	select PINCTRL_BCM2835
> > +	select ARM_AMBA
> > +	select ARM_TIMER_SP804
> > +	select HAVE_ARM_ARCH_TIMER
> > +	help
> > +	  This enables support for the Broadcom BCM2837 SoC.
> > +	  This SoC is used in the Raspberry Pi 3 device.
> > +
> >  config ARCH_BCM_IPROC
> >  	bool "Broadcom iProc SoC Family"
> > +	depends on ARCH_BCM
> 
> Does not seem necessary nor adding anything here.

Added for consistency.  When we add ARCH_BCM all ARCH_BCM_* should
depend on it ...

We could also do it the other way around: make ARCH_BCM a hidden bool
and have ARCH_BCM_* select it.

cheers,
  Gerd