linux-kernel - Re: [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex / completions ***

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57504D94.6040808@lwfinger.net>
Date:	Thu, 2 Jun 2016 10:15:32 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Arnd Bergmann <arnd@...db.de>, Binoy Jayan <binoy.jayan@...aro.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex /
 completions ***

On 06/02/2016 02:43 AM, Arnd Bergmann wrote:
> On Thursday, June 2, 2016 9:54:06 AM CEST Binoy Jayan wrote:
>> Hi,
>>
>> These are a set of patches [v2] which removes semaphores from:
>>
>> drivers/staging/rtl8712
>>
>> They build correctly (individually and as a whole).
>> NB: I have not tested this as I do not have the following hardware:
>>
>> "RealTek RTL8712U (RTL8192SU) Wireless LAN NIC driver"
>>
>> Rework on comments w.r.t. PATCH v1:
>>
>>   - Removed wrapper functions _wait_completion, _down_sema and _enter_pwrlock
>>   - Updated changelog to explain use of mutex_lock instead of
>>     mutex_lock_interruptible in [PATCH v2 4/4]
>>
>
> All four look great now,
>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>


I agree.

Tested-by: Larry Finger <Larry.Finger@...inger.net>

Larry