linux-kernel - Re: [PATCH v8 13/14] perf callchain: Support x86 target platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602203413.GB26647@krava>
Date:	Thu, 2 Jun 2016 22:34:13 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	He Kuang <hekuang@...wei.com>
Cc:	peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
	alexander.shishkin@...ux.intel.com, wangnan0@...wei.com,
	jpoimboe@...hat.com, ak@...ux.intel.com, eranian@...gle.com,
	namhyung@...nel.org, adrian.hunter@...el.com,
	sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com,
	tumanova@...ux.vnet.ibm.com, kan.liang@...el.com,
	penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 13/14] perf callchain: Support x86 target platform

On Thu, Jun 02, 2016 at 09:55:25AM +0000, He Kuang wrote:

SNIP

> @@ -31,9 +33,17 @@ int unwind__prepare_access(struct thread *thread, struct map *map)
>  		return 0;
>  
>  	arch = normalize_arch(thread->mg->machine->env->arch);
> -	pr_debug("unwind: target platform=%s\n", arch);
>  
> -	unwind__register_ops(thread, local_unwind_libunwind_ops);
> +	if (!strcmp(arch, "x86"))
> +		if (dso_type != DSO__TYPE_64BIT)
> +			ops = x86_32_unwind_libunwind_ops;

pleas enclose above into { }

thanks,
jirka