linux-kernel - Re: [PATCH v8 08/14] perf tools: Extract common API out of unwind-libunwind-local.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602203430.GC26647@krava>
Date:	Thu, 2 Jun 2016 22:34:30 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	He Kuang <hekuang@...wei.com>
Cc:	peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
	alexander.shishkin@...ux.intel.com, wangnan0@...wei.com,
	jpoimboe@...hat.com, ak@...ux.intel.com, eranian@...gle.com,
	namhyung@...nel.org, adrian.hunter@...el.com,
	sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com,
	tumanova@...ux.vnet.ibm.com, kan.liang@...el.com,
	penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 08/14] perf tools: Extract common API out of
 unwind-libunwind-local.c

On Thu, Jun 02, 2016 at 09:55:20AM +0000, He Kuang wrote:

SNIP

> +void unwind__finish_access(struct thread *thread)
> +{
> +	if (thread->unwind_libunwind_ops)
> +		thread->unwind_libunwind_ops->finish_access(thread);
> +}
> +
> +int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
> +			 struct thread *thread,
> +			 struct perf_sample *data, int max_stack)
> +{
> +	if (thread->unwind_libunwind_ops)
> +		return thread->unwind_libunwind_ops->get_entries(cb, arg,
> +								 thread,
> +								 data,
> +								 max_stack);

please enclose both if and else paths into { }
there's a rule to do that for multiple line paths

thanks,
jirka