linux-kernel - Re: [PATCH v8 03/14] perf tools: Introducing struct unwind_libunwind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jun 2016 22:34:48 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	He Kuang <hekuang@...wei.com>
Cc:	peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
	alexander.shishkin@...ux.intel.com, wangnan0@...wei.com,
	jpoimboe@...hat.com, ak@...ux.intel.com, eranian@...gle.com,
	namhyung@...nel.org, adrian.hunter@...el.com,
	sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com,
	tumanova@...ux.vnet.ibm.com, kan.liang@...el.com,
	penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 03/14] perf tools: Introducing struct
 unwind_libunwind_ops for local unwind

On Thu, Jun 02, 2016 at 09:55:15AM +0000, He Kuang wrote:

SNIP

> @@ -680,3 +680,52 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
>  
>  	return get_entries(&ui, cb, arg, max_stack);
>  }
> +
> +static struct unwind_libunwind_ops
> +_unwind_libunwind_ops = {
> +	.prepare_access = _unwind__prepare_access,
> +	.flush_access   = _unwind__flush_access,
> +	.finish_access  = _unwind__finish_access,
> +	.get_entries    = _unwind__get_entries,
> +};
> +
> +struct unwind_libunwind_ops *
> +local_unwind_libunwind_ops = &_unwind_libunwind_ops;
> +
> +void unwind__register_ops(struct thread *thread,
> +			  struct unwind_libunwind_ops *ops)
> +{
> +	thread->unwind_libunwind_ops = ops;
> +}

no need for unwind__register_ops to be global
please make it static

jirka