lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Jun 2016 22:35:04 +0200 From: Jiri Olsa <jolsa@...hat.com> To: He Kuang <hekuang@...wei.com> Cc: peterz@...radead.org, mingo@...hat.com, acme@...nel.org, alexander.shishkin@...ux.intel.com, wangnan0@...wei.com, jpoimboe@...hat.com, ak@...ux.intel.com, eranian@...gle.com, namhyung@...nel.org, adrian.hunter@...el.com, sukadev@...ux.vnet.ibm.com, masami.hiramatsu.pt@...achi.com, tumanova@...ux.vnet.ibm.com, kan.liang@...el.com, penberg@...nel.org, dsahern@...il.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH v8 00/14] Add support for remote unwind On Thu, Jun 02, 2016 at 09:55:12AM +0000, He Kuang wrote: SNIP > and now we can use LIBUNWIND_DIR to specific custom dirctories > containing libunwind libs. > > v8: > > - Put unwind__register_ops call into unwind__prepare_access from > patch 4 to patch 3. > - Fail thread__insert_map on error. > - Remove unused macro HAVE_LIBUNWIND_LOCAL_SUPPORT. > - Return once find that thread->addr_space is valid and check this > value first. > - Add comments in file 'util/libunwind/arm64.c', > 'util/libunwind/x86_32.c', and explain the reason for debug-frame > flag in non-arm arch. apart from few nitpicks, this looks ok to me I tried with 32bit unwind under 64bits and it works nicely, plus 64bit unwind seems not to be broken as well ;-) considerring those nitpicks solved: Acked-by: Jiri Olsa <jolsa@...nel.org> thanks, jirka
Powered by blists - more mailing lists