linux-kernel - Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57510093.5000702@gmail.com>
Date:	Thu, 2 Jun 2016 20:59:15 -0700
From:	Frank Rowand <frowand.list@...il.com>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>,
	Andy Gross <andy.gross@...aro.org>,
	David Brown <david.brown@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>
Cc:	linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nicolas Dechesne <nicolas.dechesne@...aro.org>,
	Ivan Ivanov <iivanov.xz@...il.com>,
	Stephen Boyd <sboyd@...eaurora.org>, stable@...r.kernel.org
Subject: Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo

On 06/02/16 17:48, Bjorn Andersson wrote:
> For dm uarts in pio mode tx data is transferred to the fifo register 4
> bytes at a time, but care is not taken when these 4 bytes spans the end
> of the xmit buffer so the loop might read up to 3 bytes past the buffer
> and then skip the actual data at the beginning of the buffer.
> 
> Fix this by, analogous to the DMA case, make sure the chunk doesn't
> wrap the xmit buffer.
> 
> Fixes: 3a878c430fd6 ("tty: serial: msm: Add TX DMA support")
> Cc: Andy Gross <andy.gross@...aro.org>
> Cc: Ivan Ivanov <iivanov.xz@...il.com>
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: stable@...r.kernel.org
> Reported-by: Frank Rowand <frowand.list@...il.com>
> Reported-by: Nicolas Dechesne <nicolas.dechesne@...aro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>  drivers/tty/serial/msm_serial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
> index b7d80bd57db9..7d62610d9de5 100644
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -726,7 +726,7 @@ static void msm_handle_tx(struct uart_port *port)
>  		return;
>  	}
>  
> -	pio_count = CIRC_CNT(xmit->head, xmit->tail, UART_XMIT_SIZE);
> +	pio_count = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
>  	dma_count = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
>  
>  	dma_min = 1;	/* Always DMA */
> 

Thanks Bjorn.  This eliminates my symptoms on 4.6 and 4.7-rc1.

Tested-by: Frank Rowand <frank.rowand@...sony.com>

-Frank