linux-kernel - Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160604000355.GX28218@codeaurora.org>
Date:	Fri, 3 Jun 2016 17:03:55 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:	Andy Gross <andy.gross@...aro.org>,
	David Brown <david.brown@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>, linux-arm-msm@...r.kernel.org,
	linux-soc@...r.kernel.org, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Frank Rowand <frowand.list@...il.com>,
	Nicolas Dechesne <nicolas.dechesne@...aro.org>,
	Ivan Ivanov <iivanov.xz@...il.com>, stable@...r.kernel.org
Subject: Re: [PATCH] tty: serial: msm: Don't read off end of tx fifo

On 06/02, Bjorn Andersson wrote:
> For dm uarts in pio mode tx data is transferred to the fifo register 4
> bytes at a time, but care is not taken when these 4 bytes spans the end
> of the xmit buffer so the loop might read up to 3 bytes past the buffer
> and then skip the actual data at the beginning of the buffer.
> 
> Fix this by, analogous to the DMA case, make sure the chunk doesn't
> wrap the xmit buffer.
> 
> Fixes: 3a878c430fd6 ("tty: serial: msm: Add TX DMA support")
> Cc: Andy Gross <andy.gross@...aro.org>
> Cc: Ivan Ivanov <iivanov.xz@...il.com>
> Cc: Stephen Boyd <sboyd@...eaurora.org>
> Cc: stable@...r.kernel.org
> Reported-by: Frank Rowand <frowand.list@...il.com>
> Reported-by: Nicolas Dechesne <nicolas.dechesne@...aro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project