linux-kernel - Re: [PATCH 17/20] x86, mmc: use Intel family name macros for mmc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 3 Jun 2016 09:42:37 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Dave Hansen <dave@...1.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	x86@...nel.org, dave.hansen@...ux.intel.com,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH 17/20] x86, mmc: use Intel family name macros for mmc driver

On 2 June 2016 at 02:12, Dave Hansen <dave@...1.net> wrote:
>
> From: Dave Hansen <dave.hansen@...ux.intel.com>
>
> Another straightforward replacement of magic numbers.
>
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: linux-mmc@...r.kernel.org

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

I assume you are going to queue this via the x86 tree or whatever tree
that makes sense!?

Kind regards
Uffe

> ---
>
>  b/drivers/mmc/host/sdhci-acpi.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN drivers/mmc/host/sdhci-acpi.c~x86-intel-families-sdhci-acpi drivers/mmc/host/sdhci-acpi.c
> --- a/drivers/mmc/host/sdhci-acpi.c~x86-intel-families-sdhci-acpi       2016-06-01 15:45:09.826201501 -0700
> +++ b/drivers/mmc/host/sdhci-acpi.c     2016-06-01 15:45:09.830201683 -0700
> @@ -43,6 +43,7 @@
>
>  #ifdef CONFIG_X86
>  #include <asm/cpu_device_id.h>
> +#include <asm/intel-family.h>
>  #include <asm/iosf_mbi.h>
>  #endif
>
> @@ -126,7 +127,7 @@ static const struct sdhci_acpi_chip sdhc
>  static bool sdhci_acpi_byt(void)
>  {
>         static const struct x86_cpu_id byt[] = {
> -               { X86_VENDOR_INTEL, 6, 0x37 },
> +               { X86_VENDOR_INTEL, 6, INTEL_FAM6_MODEL_ATOM_SILVERMONT1 },
>                 {}
>         };
>
> _