linux-kernel - Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160602214557.GB1975@f23x64.localdomain>
Date:	Thu, 2 Jun 2016 14:45:57 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Dave Hansen <dave@...1.net>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	dave.hansen@...ux.intel.com, adrian.hunter@...el.com,
	ak@...ux.intel.com, luto@...nel.org, bp@...en8.de,
	dougthompson@...ssion.com, edubezval@...il.com, hpa@...or.com,
	mingo@...hat.com, jacob.jun.pan@...ux.intel.com,
	kan.liang@...el.com, lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-edac@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux-pm@...r.kernel.org, mchehab@....samsung.com,
	peterz@...radead.org, platform-driver-x86@...r.kernel.org,
	rafael.j.wysocki@...el.com, rajneesh.bhardwaj@...el.com,
	souvik.k.chakravarty@...el.com,
	srinivas.pandruvada@...ux.intel.com, eranian@...gle.com,
	tglx@...utronix.de, tony.luck@...el.com, ulf.hansson@...aro.org,
	viresh.kumar@...aro.org, vishwanath.somayaji@...el.com,
	zheng.z.yan@...el.com, rui.zhang@...el.com
Subject: Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family
 numbers

On Wed, Jun 01, 2016 at 05:11:57PM -0700, Dave Hansen wrote:
> 
> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> If you are cc'd on this code, please check _your_ code vs. the
> model list in "intel-family.h".  Please make sure you have all
> the models listed that you intend to.
> 
> Problem:
> 
> We have a boatload of open-coded family-6 model numbers.  Half of
> them have these model numbers in hex and the other half in
> decimal.  This makes grepping for them tons of fun, if you were
> to try.
> 
> Solution:
> 
> Consolidate all the magic numbers.  Put all the definitions in
> one header.
> 
> The names here are closely derived from the comments describing
> the models from arch/x86/events/intel/core.c.  We could easily
> make them shorter by doing things like s/SANDYBRIDGE/SNB/, but
> they seemed fine even with the longer versions to me.
> 
> Do not take any of these names too literally, like "DESKTOP"
> or "MOBILE".  These are all colloquial names and not precise
> descriptions of everywhere a given model will show up.
> 
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Darren Hart <dvhart@...radead.org>

For platform/drivers/x86:

Magic number to macro mapping verified.

Acked-by: Darren Hart <dvhart@...ux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center