linux-kernel - Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025489.OPKq8WOssX@vostro.rjw.lan>
Date:	Thu, 02 Jun 2016 23:49 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave@...1.net>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	dave.hansen@...ux.intel.com, adrian.hunter@...el.com,
	ak@...ux.intel.com, luto@...nel.org, dvhart@...radead.org,
	dougthompson@...ssion.com, edubezval@...il.com, hpa@...or.com,
	mingo@...hat.com, jacob.jun.pan@...ux.intel.com,
	kan.liang@...el.com, lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-edac@...r.kernel.org, linux-mmc@...r.kernel.org,
	linux-pm@...r.kernel.org, mchehab@....samsung.com,
	peterz@...radead.org, platform-driver-x86@...r.kernel.org,
	rafael.j.wysocki@...el.com, rajneesh.bhardwaj@...el.com,
	souvik.k.chakravarty@...el.com,
	srinivas.pandruvada@...ux.intel.com, eranian@...gle.com,
	tglx@...utronix.de, tony.luck@...el.com, ulf.hansson@...aro.org,
	viresh.kumar@...aro.org, vishwanath.somayaji@...el.com,
	zheng.z.yan@...el.com, rui.zhang@...el.com
Subject: Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers

On Thursday, June 02, 2016 08:57:15 AM Borislav Petkov wrote:
> On Wed, Jun 01, 2016 at 05:11:57PM -0700, Dave Hansen wrote:
> > +#define INTEL_FAM6_MODEL_CORE_YONAH		0x0E
> > +#define INTEL_FAM6_MODEL_CORE2_MEROM		0x0F
> 
> That "MODEL_" part looks redundant too IMO - you could simply do
> 
> INTEL_FAM6_NEHALEM and
> INTEL_FAM6_SKYLAKE_DESKTOP
> ...
> 
> and so on and it is still clear what it is.

I'm with you on that, but that's rather minor and the changes in this series
are generally fine by me, so Dave please feel free to add

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

to all of it.

Thanks,
Rafael