linux-kernel - RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F3A101C74@ORSMSX113.amr.corp.intel.com>
Date:	Thu, 2 Jun 2016 17:27:13 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Dave Hansen <dave@...1.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"x86@...nel.org" <x86@...nel.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"mchehab@....samsung.com" <mchehab@....samsung.com>,
	"dougthompson@...ssion.com" <dougthompson@...ssion.com>,
	"bp@...en8.de" <bp@...en8.de>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac
 driver

> This needs to add an entry for BDX-DE (use the same table initializer). Probably as
> a separate patch before/after this.

Oops ... a bit worse than that. I assumed that index into the array matches the
enum ... (with a comment!) ... having two entries for the same "type" would break
that. I'll have to add a type field to something.

If your patch is on a fast-track, then go ahead with it:

Acked-by: Tony Luck <tony.luck@...el.com>

I'll work on fixing the other mess independently

-Tony